Implement conditional Cocoa linking for targets #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raph Co-authored-by: giancarlo.buenaflor <[email protected]>
Co-authored-by: giancarlo.buenaflor <[email protected]>
buenaflor
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 79.32% 75.29% -4.04%
==========================================
Files 11 11
Lines 324 344 +20
Branches 49 52 +3
==========================================
+ Hits 257 259 +2
- Misses 39 57 +18
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
buenaflor
changed the title
|
I think the coverage doesn't account for the integration test? |
|
@romtsn this should be good to go |
romtsn
reviewed
Jul 16, 2025
...tiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Jul 16, 2025
...tiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Jul 16, 2025
ah right, I'll have a look at that again when I have time |
buenaflor
deleted the
cursor/implement-conditional-cocoa-linking-for-targets-aebb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Moved Sentry Cocoa framework linking configuration to execute only when Apple targets are present in the Gradle task graph. This prevents unnecessary execution of Cocoa-specific logic for non-Apple builds
💡 Motivation and Context
Previously, the plugin would eagerly configure Cocoa framework linking on macOS, even if the build only involved Android or JVM targets. This could lead to build failures if the Sentry Cocoa XCFramework was not found, despite not being needed. This change ensures the linking setup is deferred and only runs when relevant, improving build robustness and efficiency for mixed-platform projects.
💚 How did you test it?
Integration test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps